]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fs: dodge an atomic in putname if ref == 1
authorMateusz Guzik <mjguzik@gmail.com>
Tue, 11 Mar 2025 18:18:04 +0000 (19:18 +0100)
committerChristian Brauner <brauner@kernel.org>
Wed, 12 Mar 2025 08:35:33 +0000 (09:35 +0100)
commit86f40fa6a4675ecfe554c360ab022294742c9a01
tree9538d6149d275068669a896c42834fca63fc1831
parent93fd0d46cbf7bc35a3a912c913b4f074955119c7
fs: dodge an atomic in putname if ref == 1

While the structure is refcounted, the only consumer incrementing it is
audit and even then the atomic operation is only needed when it
interacts with io_uring.

If putname spots a count of 1, there is no legitimate way for anyone to
bump it.

If audit is disabled, the count is guaranteed to be 1, which
consistently elides the atomic for all path lookups. If audit is
enabled, it still manages to elide the last decrement.

Note the patch does not do anything to prevent audit from suffering
atomics. See [1] and [2] for a different approach.

Benchmarked on Sapphire Rapids issuing access() (ops/s):
before: 5106246
after:  5269678 (+3%)

Link 1: https://lore.kernel.org/linux-fsdevel/20250307161155.760949-1-mjguzik@gmail.com/
Link 2: https://lore.kernel.org/linux-fsdevel/20250307164216.GI2023217@ZenIV/

Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Link: https://lore.kernel.org/r/20250311181804.1165758-1-mjguzik@gmail.com
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/namei.c