]> www.infradead.org Git - users/willy/xarray.git/commit
media: rkisp1: Fix unused value issue
authorDheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
Tue, 19 Nov 2024 07:26:53 +0000 (12:56 +0530)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 6 Dec 2024 14:51:32 +0000 (15:51 +0100)
commit86e5e8efb82cbee416e726e141decdc9e1a2d5f3
tree8110fcc28c8770477ec708ba6a3886d7db7f55e6
parentd1028b5748164e3ddd6d2bb0bbceee846ed2fc71
media: rkisp1: Fix unused value issue

This commit fixes an unused value issue detected by Coverity (CID
1519008). The error condition for the invalid MIPI CSI-2 is not properly
handled as the break statement would only exit the switch block and not
the entire loop. Fix this by breaking from the look immediately after
the switch block when an error occurs.

Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
Fixes: 7d4f126fde89 ("media: rkisp1: Make the internal CSI-2 receiver optional")
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Link: https://lore.kernel.org/r/20241119072653.72260-1-dheeraj.linuxdev@gmail.com
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c