]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: dsa: lantiq_gswip: do also enable or disable cpu port
authorMartin Schiller <ms@dev.tdt.de>
Tue, 11 Jun 2024 13:54:28 +0000 (15:54 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 14 Jun 2024 00:07:11 +0000 (17:07 -0700)
commit86b9ea6412af41914ef6549f85a849c3b987f4f3
treee9ba4b9cd1c28882a942fcb7c2f2b354762beab3
parentf5ebf9ab60940b00c36dfe64add41c80f3daff6a
net: dsa: lantiq_gswip: do also enable or disable cpu port

Before commit 74be4babe72f ("net: dsa: do not enable or disable non user
ports"), gswip_port_enable/disable() were also executed for the cpu port
in gswip_setup() which disabled the cpu port during initialization.

Let's restore this by removing the dsa_is_user_port checks. Also, let's
clean up the gswip_port_enable() function so that we only have to check
for the cpu port once. The operation reordering done here is safe.

Signed-off-by: Martin Schiller <ms@dev.tdt.de>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20240611135434.3180973-7-ms@dev.tdt.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/lantiq_gswip.c