]> www.infradead.org Git - users/jedix/linux-maple.git/commit
staging: vc04_services: vchiq_core: Stop kthreads on vchiq module unload
authorUmang Jain <umang.jain@ideasonboard.com>
Wed, 3 Jul 2024 13:10:52 +0000 (18:40 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Jul 2024 12:51:18 +0000 (14:51 +0200)
commit863a756aaf49ed23d25bbb1dad999a85f09e1836
treea960bcfd95f2936bfeccaa85ac54cff15fd47909
parentc22502cb84d4c963f754e6d943d3133cfa80ba97
staging: vc04_services: vchiq_core: Stop kthreads on vchiq module unload

The various kthreads thread functions (slot_handler_func, sync_func,
recycle_func) in vchiq_core and vchiq_keepalive_thread_func in
vchiq_arm should be stopped when the module is unloaded.

Previous attempt were made to address this but later reverted [1]
due to VC04 firmware corruption. The issue around
wait_event_interruptible() handling on stopping a kthread has been
handled in the previous commit. Hence, it is now safe to stop kthreads
on module unload, without any firmware corruption.

This also completes the "Fix kernel module support" TODO item, hence
drop it from the list.

[1] commit ebee9ca2f59e ("Revert "staging: vc04_services: vchiq_core: Stop kthreads on shutdown"")

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Tested-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20240703131052.597443-3-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/TODO
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c