]> www.infradead.org Git - users/jedix/linux-maple.git/commit
HID: wacom: fix kobject reference count leak
authorQasim Ijaz <qasdev00@gmail.com>
Fri, 6 Jun 2025 18:49:59 +0000 (19:49 +0100)
committerJiri Kosina <jkosina@suse.com>
Tue, 10 Jun 2025 19:10:27 +0000 (21:10 +0200)
commit85a720f4337f0ddf1603c8b75a8f1ffbbe022ef9
treea7a39af1eda16dff26cc3b8b3d02f8a97e9e6a98
parent1a19ae437ca5d5c7d9ec2678946fb339b1c706bf
HID: wacom: fix kobject reference count leak

When sysfs_create_files() fails in wacom_initialize_remotes() the error
is returned and the cleanup action will not have been registered yet.

As a result the kobject???s refcount is never dropped, so the
kobject can never be freed leading to a reference leak.

Fix this by calling kobject_put() before returning.

Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically allocated")
Acked-by: Ping Cheng <ping.cheng@wacom.com>
Cc: stable@vger.kernel.org
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/wacom_sys.c