]> www.infradead.org Git - users/jedix/linux-maple.git/commit
nvme: clear the request_queue pointers on failure in nvme_alloc_admin_tag_set
authorMaurizio Lombardi <mlombard@redhat.com>
Fri, 27 Jan 2023 15:42:37 +0000 (16:42 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Feb 2023 11:59:44 +0000 (12:59 +0100)
commit84ea5242b723573d1bc78049128a8b61d2c60465
tree2607126021e4112770519858b91719773dd052f1
parentfd646ac5403f9a6d693065edeb21fec2a8b19727
nvme: clear the request_queue pointers on failure in nvme_alloc_admin_tag_set

[ Upstream commit fd62678ab55cb01e11a404d302cdade222bf4022 ]

If nvme_alloc_admin_tag_set() fails, the admin_q and fabrics_q pointers
are left with an invalid, non-NULL value. Other functions may then check
the pointers and dereference them, e.g. in

  nvme_probe() -> out_disable: -> nvme_dev_remove_admin().

Fix the bug by setting admin_q and fabrics_q to NULL in case of error.

Also use the set variable to free the tag_set as ctrl->admin_tagset isn't
initialized yet.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nvme/host/core.c