]> www.infradead.org Git - nvme.git/commit
serial: sc16is7xx: fix bug in sc16is7xx_set_baud() when using prescaler
authorHugo Villeneuve <hvilleneuve@dimonoff.com>
Tue, 30 Apr 2024 20:04:30 +0000 (16:04 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 May 2024 16:14:14 +0000 (18:14 +0200)
commit8492bd91aa055907c67ef04f2b56f6dadd1f44bf
treef64c3080c4bc5af7589247ccf218a56ec5f819fa
parent614a19b89ca43449196a8af1afac7d55c6781687
serial: sc16is7xx: fix bug in sc16is7xx_set_baud() when using prescaler

When using a high speed clock with a low baud rate, the 4x prescaler is
automatically selected if required. In that case, sc16is7xx_set_baud()
properly configures the chip registers, but returns an incorrect baud
rate by not taking into account the prescaler value. This incorrect baud
rate is then fed to uart_update_timeout().

For example, with an input clock of 80MHz, and a selected baud rate of 50,
sc16is7xx_set_baud() will return 200 instead of 50.

Fix this by first changing the prescaler variable to hold the selected
prescaler value instead of the MCR bitfield. Then properly take into
account the selected prescaler value in the return value computation.

Also add better documentation about the divisor value computation.

Fixes: dfeae619d781 ("serial: sc16is7xx")
Cc: stable@vger.kernel.org
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20240430200431.4102923-1-hugo@hugovil.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sc16is7xx.c