]> www.infradead.org Git - users/jedix/linux-maple.git/commit
r8152: fix the firmware doesn't work
authorHayes Wang <hayeswang@realtek.com>
Tue, 3 Sep 2024 06:33:33 +0000 (14:33 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 4 Sep 2024 23:34:06 +0000 (16:34 -0700)
commit8487b4af59d4d7feda4b119dc2d92c67ca25c27e
treeca6b9f4f30e56d18320080efd3215620d86e982d
parent7e4196935069947d8b70b09c1660b67b067e75cb
r8152: fix the firmware doesn't work

generic_ocp_write() asks the parameter "size" must be 4 bytes align.
Therefore, write the bp would fail, if the mac->bp_num is odd. Align the
size to 4 for fixing it. The way may write an extra bp, but the
rtl8152_is_fw_mac_ok() makes sure the value must be 0 for the bp whose
index is more than mac->bp_num. That is, there is no influence for the
firmware.

Besides, I check the return value of generic_ocp_write() to make sure
everything is correct.

Fixes: e5c266a61186 ("r8152: set bp in bulk")
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Link: https://patch.msgid.link/20240903063333.4502-1-hayeswang@realtek.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/r8152.c