]> www.infradead.org Git - users/dwmw2/linux.git/commit
netfilter: ipset: fix region locking in hash types
authorJozsef Kadlecsik <kadlec@netfilter.org>
Wed, 7 May 2025 15:01:59 +0000 (17:01 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 7 May 2025 21:57:31 +0000 (23:57 +0200)
commit8478a729c0462273188263136880480729e9efca
tree056118cab6e2f9604dea91b13d8b03c8f6b8d265
parente34090d7214e0516eb8722aee295cb2507317c07
netfilter: ipset: fix region locking in hash types

Region locking introduced in v5.6-rc4 contained three macros to handle
the region locks: ahash_bucket_start(), ahash_bucket_end() which gave
back the start and end hash bucket values belonging to a given region
lock and ahash_region() which should give back the region lock belonging
to a given hash bucket. The latter was incorrect which can lead to a
race condition between the garbage collector and adding new elements
when a hash type of set is defined with timeouts.

Fixes: f66ee0410b1c ("netfilter: ipset: Fix "INFO: rcu detected stall in hash_xxx" reports")
Reported-by: Kota Toda <kota.toda@gmo-cybersecurity.com>
Signed-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/ipset/ip_set_hash_gen.h