]> www.infradead.org Git - users/dwmw2/qemu.git/commit
cutils: Document differences between parse_uint and qemu_strtou64
authorEric Blake <eblake@redhat.com>
Mon, 22 May 2023 19:04:28 +0000 (14:04 -0500)
committerEric Blake <eblake@redhat.com>
Fri, 2 Jun 2023 17:23:33 +0000 (12:23 -0500)
commit84760bbca9a4ef1bfb38b9c101a2604e5d429605
tree6c20ea817d8123a94a194d3bbadae68886eed682
parent56ddafde3f68b27123281dde3f48b5e945c86b48
cutils: Document differences between parse_uint and qemu_strtou64

These two functions are subtly different, and not just because of
swapped parameter order.  It took me adding better unit tests to
figure out why.  Document the differences to make it more obvious to
developers trying to pick which one to use, as well as to aid in
upcoming semantic changes.

While touching the documentation, adjust a mis-statement: parse_uint
does not return -EINVAL on invalid base, but assert()s, like all the
other qemu_strto* functions that take a base argument.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230522190441.64278-7-eblake@redhat.com>
util/cutils.c