]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: rtw89: debugfs: implement file_ops::read/write to replace seq_file
authorPing-Ke Shih <pkshih@realtek.com>
Wed, 22 Jan 2025 06:03:03 +0000 (14:03 +0800)
committerPing-Ke Shih <pkshih@realtek.com>
Mon, 3 Feb 2025 02:24:26 +0000 (10:24 +0800)
commit831cceed3baf498984add821d288ced95a4ec4cf
tree62629f4c970c82393c17c0e32c4dcb2a3dbda624
parent4afde17d266795eff3ebb94526c7b04ea876259d
wifi: rtw89: debugfs: implement file_ops::read/write to replace seq_file

Since debugfs needs wiphy lock held, wiphy_locked_debugfs_{read,write}()
will be adopted, so implmenet file_ops::read/write along with their
arguments.

For reading part, it needs lots of changes because seq_file is not
suitable for wiphy_locked_debugfs_{read,write}(), so use spatch script
below to convert basically, and manually implement the functions.

  @ rule1 @
  identifier m;
  @@

  - seq_printf(m,
  + p += scnprintf(p, end - p,
    ...)

  @ rule2 @
  identifier m;
  @@

  - seq_puts(m,
  + p += scnprintf(p, end - p,
    ...)

For current version, only 4K buffer to output. To note ourselves, add
ellipsis symbol "..." to trailing if buffer is full. Later, add an option
to specify buffer size needed by a debugfs entry.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20250122060310.31976-4-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/coex.c
drivers/net/wireless/realtek/rtw89/coex.h
drivers/net/wireless/realtek/rtw89/debug.c
drivers/net/wireless/realtek/rtw89/phy.c
drivers/net/wireless/realtek/rtw89/phy.h
drivers/net/wireless/realtek/rtw89/sar.c
drivers/net/wireless/realtek/rtw89/sar.h
drivers/net/wireless/realtek/rtw89/util.c
drivers/net/wireless/realtek/rtw89/util.h