]> www.infradead.org Git - users/willy/xarray.git/commit
mm: prevent derefencing NULL ptr in pfn_section_valid()
authorWaiman Long <longman@redhat.com>
Wed, 26 Jun 2024 00:16:39 +0000 (20:16 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 4 Jul 2024 05:40:36 +0000 (22:40 -0700)
commit82f0b6f041fad768c28b4ad05a683065412c226e
tree7f007bc0ea6844f3ca068f8321d4fd83628dbfa5
parentfa2690af573dfefb47ba6eef888797a64b6b5f3c
mm: prevent derefencing NULL ptr in pfn_section_valid()

Commit 5ec8e8ea8b77 ("mm/sparsemem: fix race in accessing
memory_section->usage") changed pfn_section_valid() to add a READ_ONCE()
call around "ms->usage" to fix a race with section_deactivate() where
ms->usage can be cleared.  The READ_ONCE() call, by itself, is not enough
to prevent NULL pointer dereference.  We need to check its value before
dereferencing it.

Link: https://lkml.kernel.org/r/20240626001639.1350646-1-longman@redhat.com
Fixes: 5ec8e8ea8b77 ("mm/sparsemem: fix race in accessing memory_section->usage")
Signed-off-by: Waiman Long <longman@redhat.com>
Cc: Charan Teja Kalla <quic_charante@quicinc.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/mmzone.h