]> www.infradead.org Git - users/jedix/linux-maple.git/commit
NFSv4.1: nfs4_fl_prepare_ds must be careful about reporting success.
authorNeilBrown <neilb@suse.com>
Mon, 19 Dec 2016 00:19:31 +0000 (11:19 +1100)
committerBrian Maly <brian.maly@oracle.com>
Tue, 9 Apr 2019 21:05:44 +0000 (17:05 -0400)
commit82e8a1994b8ce1edc2ee7124f481f06c49a5d23f
tree15eb998fb8f1817a014bd019afcb308b81b14ced
parente7c19601874a83e2cbda63f8b5baad26d8bd93a2
NFSv4.1: nfs4_fl_prepare_ds must be careful about reporting success.

Various places assume that if nfs4_fl_prepare_ds() turns a non-NULL 'ds',
then ds->ds_clp will also be non-NULL.

This is not necessasrily true in the case when the process received a fatal signal
while nfs4_pnfs_ds_connect is waiting in nfs4_wait_ds_connect().
In that case ->ds_clp may not be set, and the devid may not recently have been marked
unavailable.

So add a test for ds_clp == NULL and return NULL in that case.

Fixes: c23266d532b4 ("NFS4.1 Fix data server connection race")
Signed-off-by: NeilBrown <neilb@suse.com>
Acked-by: Olga Kornievskaia <aglo@umich.edu>
Acked-by: Adamson, Andy <William.Adamson@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
(cherry picked from commit cfd278c280f997cf2fe4662e0acab0fe465f637b)
Orabug: 29617508
Signed-off-by: Calum Mackay <calum.mackay@oracle.com>
Reviewed-by: John Sobecki <john.sobecki@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
fs/nfs/filelayout/filelayoutdev.c