]> www.infradead.org Git - users/dwmw2/qemu.git/commit
ui: fix handling of NULL SASL server data
authorDaniel P. Berrangé <berrange@redhat.com>
Mon, 16 Sep 2024 12:47:11 +0000 (13:47 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Tue, 22 Oct 2024 10:44:23 +0000 (11:44 +0100)
commit829cb3d0eab08e4fea768926f06db1c411a2767f
treef2c7789728242c8d47e753a6af9260af77e6e8d9
parent2b69564798f3cd43ab9bdf70a96d2373cb544a9a
ui: fix handling of NULL SASL server data

The code is supposed to distinguish between SASL server data that
is NULL, vs non-NULL but zero-length. It was incorrectly checking
the 'serveroutlen' variable, rather than 'serverout' though, so
failing to distinguish the cases.

Fortunately we can fix this without breaking compatibility with
clients, as clients already know how to decode the input data
correctly.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
ui/vnc-auth-sasl.c