]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/xe: Don't free job in TDR
authorMatthew Brost <matthew.brost@intel.com>
Thu, 3 Oct 2024 00:16:57 +0000 (17:16 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Wed, 16 Oct 2024 14:00:22 +0000 (09:00 -0500)
commit82926f52d7a09c65d916c0ef8d4305fc95d68c0c
tree472e6e8df1d9b5eccff2ba7e4060d460b24dccb1
parented931fb40e353586f26c3327813d142f782f5f78
drm/xe: Don't free job in TDR

Freeing job in TDR is not safe as TDR can pass the run_job thread
resulting in UAF. It is only safe for free job to naturally be called by
the scheduler. Rather free job in TDR, add to pending list.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2811
Cc: Matthew Auld <matthew.auld@intel.com>
Fixes: e275d61c5f3f ("drm/xe/guc: Handle timing out of signaled jobs gracefully")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241003001657.3517883-3-matthew.brost@intel.com
(cherry picked from commit ea2f6a77d0c40d97f4a4dc93fee4afe15d94926d)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_guc_submit.c