]> www.infradead.org Git - users/dwmw2/linux.git/commit
qlge: Avoid reading past end of buffer
authorKees Cook <keescook@chromium.org>
Fri, 5 May 2017 22:34:34 +0000 (15:34 -0700)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:23 +0000 (21:36 -0400)
commit82271d92808b6c7e79a01c4294da1e9ec3031ded
tree278b7c3ec599da967d78f75448ba6b1c16a7a865
parent1935e7e46007c4cd2ef65ccf609f8378bd0437de
qlge: Avoid reading past end of buffer

[ Upstream commit df5303a8aa9a0a6934f4cea7427f1edf771f21c2 ]

Using memcpy() from a string that is shorter than the length copied means
the destination buffer is being filled with arbitrary data from the kernel
rodata segment. Instead, use strncpy() which will fill the trailing bytes
with zeros.

This was found with the future CONFIG_FORTIFY_SOURCE feature.

Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/net/ethernet/qlogic/qlge/qlge_dbg.c