]> www.infradead.org Git - users/willy/xarray.git/commit
media: ov2740: Move pm-runtime cleanup on probe-errors to proper place
authorHans de Goede <hdegoede@redhat.com>
Mon, 24 Mar 2025 13:01:09 +0000 (14:01 +0100)
committerHans Verkuil <hverkuil@xs4all.nl>
Fri, 25 Apr 2025 08:15:23 +0000 (10:15 +0200)
commit81cf4f46a03a07b0b86f9d677c34ba782df7d65e
tree1e5a695750213b420f593c5f2f6285fb2786af57
parent1acf9fee6f117fcb91da3c8f36545d7051c78f52
media: ov2740: Move pm-runtime cleanup on probe-errors to proper place

When v4l2_subdev_init_finalize() fails no changes have been made to
the runtime-pm device state yet, so the probe_error_media_entity_cleanup
rollback path should not touch the runtime-pm device state.

Instead this should be done from the probe_error_v4l2_subdev_cleanup
rollback path. Note the pm_runtime_xxx() calls are put above
the v4l2_subdev_cleanup() call to have the reverse call order of probe().

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
Fixes: 289c25923ecd ("media: ov2740: Use sub-device active state")
Cc: stable@vger.kernel.org
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/ov2740.c