]> www.infradead.org Git - users/dwmw2/linux.git/commit
net/rose: Fix Use-After-Free in rose_ioctl
authorHyunwoo Kim <v4bel@theori.io>
Sat, 9 Dec 2023 10:05:38 +0000 (05:05 -0500)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 12 Dec 2023 12:24:58 +0000 (13:24 +0100)
commit810c38a369a0a0ce625b5c12169abce1dd9ccd53
tree244458a236eab79a927e20db2ed3fa88ba89d8a6
parent24e90b9e34f9e039f56b5f25f6e6eb92cdd8f4b3
net/rose: Fix Use-After-Free in rose_ioctl

Because rose_ioctl() accesses sk->sk_receive_queue
without holding a sk->sk_receive_queue.lock, it can
cause a race with rose_accept().
A use-after-free for skb occurs with the following flow.
```
rose_ioctl() -> skb_peek()
rose_accept() -> skb_dequeue() -> kfree_skb()
```
Add sk->sk_receive_queue.lock to rose_ioctl() to fix this issue.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Hyunwoo Kim <v4bel@theori.io>
Link: https://lore.kernel.org/r/20231209100538.GA407321@v4bel-B760M-AORUS-ELITE-AX
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/rose/af_rose.c