]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/msm/gpu: Fix potential double-free
authorRob Clark <robdclark@chromium.org>
Tue, 10 Jan 2023 21:28:59 +0000 (13:28 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Feb 2023 07:34:09 +0000 (08:34 +0100)
commit8103d53f25ec7b9aa99c134642c6e840e896be71
tree1d1fa6a12fcf3722a31a446e4275bbee5b2042b8
parentba4ca7d2dd85bf46ca22c89209ad1093517acb8f
drm/msm/gpu: Fix potential double-free

[ Upstream commit a66f1efcf748febea7758c4c3c8b5bc5294949ef ]

If userspace was calling the MSM_SET_PARAM ioctl on multiple threads to
set the COMM or CMDLINE param, it could trigger a race causing the
previous value to be kfree'd multiple times.  Fix this by serializing on
the gpu lock.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Fixes: d4726d770068 ("drm/msm: Add a way to override processes comm/cmdline")
Patchwork: https://patchwork.freedesktop.org/patch/517778/
Link: https://lore.kernel.org/r/20230110212903.1925878-1-robdclark@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/msm/adreno/adreno_gpu.c
drivers/gpu/drm/msm/msm_gpu.c
drivers/gpu/drm/msm/msm_gpu.h