]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: iwlwifi: avoid memory leak
authorMiri Korenblit <miriam.rachel.korenblit@intel.com>
Sat, 28 Dec 2024 20:34:15 +0000 (22:34 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 13 Jan 2025 14:26:40 +0000 (15:26 +0100)
commit80e96206a3ef348fbd658d98f2f43149c36df8bc
tree6283eb1d726d95480b9a22a423f803d3d6be39c3
parentf24501c928a5afc60ef4a13e7b8fd4d2bcd6acb4
wifi: iwlwifi: avoid memory leak

A caller of iwl_acpi_get_dsm_object must free the returned object.
iwl_acpi_get_dsm_integer returns immediately without freeing
it if the expected size is more than 8 bytes. Fix that.

Note that with the current code this will never happen, since the caller
of iwl_acpi_get_dsm_integer already checks that the expected size if
either 1 or 4 bytes, so it can't exceed 8 bytes.

While at it, print the DSM value instead of the return value, as this
was the intention in the first place.

Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20241228223206.bf61eaab99f8.Ibdc5df02f885208c222456d42c889c43b7e3b2f7@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/fw/acpi.c