]> www.infradead.org Git - users/jedix/linux-maple.git/commit
lib: proportion: lower PROP_MAX_SHIFT to 32 on 64-bit kernel
authorWu Fengguang <fengguang.wu@intel.com>
Mon, 9 Jan 2012 17:53:50 +0000 (11:53 -0600)
committerMaxim Uvarov <maxim.uvarov@oracle.com>
Wed, 4 Apr 2012 21:39:04 +0000 (14:39 -0700)
commit7fdf145cd52254049de607adaa8e67d977f9f9d6
treeb8a714c87a59e4c06f1ead703e659849511205d0
parent950c59856b44507d1d20152adc832ec59a01fc2a
lib: proportion: lower PROP_MAX_SHIFT to 32 on 64-bit kernel

commit 3310225dfc71a35a2cc9340c15c0e08b14b3c754 upstream.

PROP_MAX_SHIFT should be set to <=32 on 64-bit box. This fixes two bugs
in the below lines of bdi_dirty_limit():

bdi_dirty *= numerator;
do_div(bdi_dirty, denominator);

1) divide error: do_div() only uses the lower 32 bit of the denominator,
   which may trimmed to be 0 when PROP_MAX_SHIFT > 32.

2) overflow: (bdi_dirty * numerator) could easily overflow if numerator
   used up to 48 bits, leaving only 16 bits to bdi_dirty

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Reported-by: Ilya Tumaykin <librarian_rus@yahoo.com>
Tested-by: Ilya Tumaykin <librarian_rus@yahoo.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/proportions.h