]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: ag71xx: remove dead code path
authorQianqiang Liu <qianqiang.liu@163.com>
Fri, 13 Sep 2024 01:47:32 +0000 (09:47 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 14 Sep 2024 02:53:47 +0000 (19:53 -0700)
commit7fd551a87ba427fee2df8af4d83f4b7c220cc9dd
tree6cd3078c6b5a8dca9a678f31d2849777d18508c1
parentef17c3d22cee57a857f3fbd3483d430fd5a44e1b
net: ag71xx: remove dead code path

The "err" is always zero, so the following branch can never be executed:
if (err) {
ndev->stats.rx_dropped++;
kfree_skb(skb);
}
Therefore, the "if" statement can be removed.

Use "ndev->stats.rx_errors" to count "napi_build_skb()" failure

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/20240911135828.378317-1-usama.anjum@collabora.com
Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
Link: https://patch.msgid.link/20240913014731.149739-1-qianqiang.liu@163.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/atheros/ag71xx.c