]> www.infradead.org Git - users/jedix/linux-maple.git/commit
dm-integrity: Avoid divide by zero in table status in Inline mode
authorMilan Broz <gmazyland@gmail.com>
Sun, 16 Feb 2025 10:42:09 +0000 (11:42 +0100)
committerMikulas Patocka <mpatocka@redhat.com>
Mon, 17 Feb 2025 10:33:07 +0000 (11:33 +0100)
commit7fb39882b20c98a9a393c244c86b56ef6933cff8
tree3e86a3d1a4ad6d726cce2a3bb32f28a860209d76
parent0ad2507d5d93f39619fc42372c347d6006b64319
dm-integrity: Avoid divide by zero in table status in Inline mode

In Inline mode, the journal is unused, and journal_sectors is zero.

Calculating the journal watermark requires dividing by journal_sectors,
which should be done only if the journal is configured.

Otherwise, a simple table query (dmsetup table) can cause OOPS.

This bug did not show on some systems, perhaps only due to
compiler optimization.

On my 32-bit testing machine, this reliably crashes with the following:

 : Oops: divide error: 0000 [#1] PREEMPT SMP
 : CPU: 0 UID: 0 PID: 2450 Comm: dmsetup Not tainted 6.14.0-rc2+ #959
 : EIP: dm_integrity_status+0x2f8/0xab0 [dm_integrity]
 ...

Signed-off-by: Milan Broz <gmazyland@gmail.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Fixes: fb0987682c62 ("dm-integrity: introduce the Inline mode")
Cc: stable@vger.kernel.org # 6.11+
drivers/md/dm-integrity.c