]> www.infradead.org Git - users/dwmw2/linux.git/commit
bnxt_en: Fix AGG ring check logic in bnxt_check_rings()
authorSomnath Kotur <somnath.kotur@broadcom.com>
Tue, 12 Dec 2023 00:51:11 +0000 (16:51 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 13 Dec 2023 00:05:57 +0000 (16:05 -0800)
commit7fb17a0c18b68b64d0d91480b558089dec017e63
treebc10b7a24d83b5ce44c63686542567a56ba9e009
parentf1e50b276d37f21b10c4d122e02a81cd202cde3b
bnxt_en: Fix AGG ring check logic in bnxt_check_rings()

_bnxt_get_max_rings() that is invoked in bnxt_check_rings() already
accounts for the AGG ring(s) and gives a max value based on that.
Increasing for AGG rings before calling _bnxt_get_max_rings() will
result in checking for twice the number of rings than required and
it can fail.  Fix it by adjusting for AGG rings after calling
_bnxt_get_max_rings().

Fixes: f5b29c6afe36 ("bnxt_en: Add helper to get the number of CP rings required for TX rings")
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/20231212005122.2401-3-michael.chan@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c