]> www.infradead.org Git - users/hch/block.git/commit
dm: Call dm_revalidate_zones() after setting the queue limits
authorDamien Le Moal <dlemoal@kernel.org>
Tue, 11 Jun 2024 02:36:37 +0000 (11:36 +0900)
committerJens Axboe <axboe@kernel.dk>
Sun, 16 Jun 2024 02:42:20 +0000 (20:42 -0600)
commit7f91ccd8a608dbe39b97a6e43d635378d493f77e
tree68b830b1087146c31b22791f0fc1c8d1c1404c52
parente21d12c7cd5cef8a6c5367f96aaab01249216ded
dm: Call dm_revalidate_zones() after setting the queue limits

dm_revalidate_zones() is called from dm_set_zone_restrictions() when the
mapped device queue limits are not yet set. However,
dm_revalidate_zones() calls blk_revalidate_disk_zones() and this
function consults and modifies the mapped device queue limits. Thus,
currently, blk_revalidate_disk_zones() operates on limits that are not
yet initialized.

Fix this by moving the call to dm_revalidate_zones() out of
dm_set_zone_restrictions() and into dm_table_set_restrictions() after
executing queue_limits_set().

To further cleanup dm_set_zones_restrictions(), the message about the
type of zone append (native or emulated) is also moved inside
dm_revalidate_zones().

Fixes: 1c0e720228ad ("dm: use queue_limits_set")
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Link: https://lore.kernel.org/r/20240611023639.89277-3-dlemoal@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/dm-table.c
drivers/md/dm-zone.c
drivers/md/dm.h