]> www.infradead.org Git - users/dwmw2/linux.git/commit
thermal: ACPI: Invalidate trip points with temperature of 0 or below
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 6 Jun 2024 18:27:30 +0000 (20:27 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 7 Jun 2024 11:52:17 +0000 (13:52 +0200)
commit7f18bd49cb6b6a3ab6d860fefccdc94f2a247db0
tree6b122b1758b1758306f0ba01055285d2a4658dd8
parent1af89dedc8a58006d8e385b1e0d2cd24df8a3b69
thermal: ACPI: Invalidate trip points with temperature of 0 or below

It is reported that commit 950210887670 ("thermal: core: Drop
trips_disabled bitmask") causes the maximum frequency of CPUs to drop
further down with every system sleep-wake cycle on Intel Core i7-4710HQ.

This turns out to be due to a trip point whose temperature is equal to 0
degrees Celsius which is acted on every time the system wakes from sleep.

Before commit 950210887670 this trip point would be disabled wia the
trips_disabled bitmask, but now it is treated as a valid one.

Since ACPI thermal control is generally about protection against
overheating, trip points with temperature of 0 centigrade or below are
not particularly useful there, so initialize them all as invalid which
fixes the problem at hand.

Fixes: 950210887670 ("thermal: core: Drop trips_disabled bitmask")
Closes: https://lore.kernel.org/linux-pm/3f71747b-f852-4ee0-b384-cf46b2aefa3f@gmx.com
Reported-by: Tibor Billes <tbilles@gmx.com>
Tested-by: Tibor Billes <tbilles@gmx.com>
Cc: 6.7+ <stable@vger.kernel.org> # 6.7+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/thermal.c