]> www.infradead.org Git - users/jedix/linux-maple.git/commit
netdev-genl: fix error codes when outputting XDP features
authorJakub Kicinski <kuba@kernel.org>
Thu, 13 Jun 2024 21:30:44 +0000 (14:30 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 15 Jun 2024 01:04:29 +0000 (18:04 -0700)
commit7ed352d34f1a09a7659c53de07785115587499fe
tree77a06280ef0c3a983e3704889d0a0b546a34f684
parentc64da10adb57a135bf91e32202d7077931472533
netdev-genl: fix error codes when outputting XDP features

-EINVAL will interrupt the dump. The correct error to return
if we have more data to dump is -EMSGSIZE.

Discovered by doing:

  for i in `seq 80`; do ip link add type veth; done
  ./cli.py --dbg-small-recv 5300 --spec netdev.yaml --dump dev-get >> /dev/null
  [...]
     nl_len = 64 (48) nl_flags = 0x0 nl_type = 19
     nl_len = 20 (4) nl_flags = 0x2 nl_type = 3
   error: -22

Fixes: d3d854fd6a1d ("netdev-genl: create a simple family for netdev stuff")
Reviewed-by: Amritha Nambiar <amritha.nambiar@intel.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20240613213044.3675745-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/netdev-genl.c