]> www.infradead.org Git - users/jedix/linux-maple.git/commit
qed: fix possible uninit pointer read in qed_mcp_nvm_info_populate()
authorGianfranco Trad <gianf.trad@gmail.com>
Sun, 15 Dec 2024 01:17:34 +0000 (02:17 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 17 Dec 2024 14:08:52 +0000 (15:08 +0100)
commit7ed2d91588779f0a2b27fd502ce2aaf1fab9b3ca
tree0bd42b237f9aff8edf7c30bc31b63379fdcb6bab
parent0cb2c504d79e7caa3abade3f466750c82ad26f01
qed: fix possible uninit pointer read in qed_mcp_nvm_info_populate()

Coverity reports an uninit pointer read in qed_mcp_nvm_info_populate().
If EOPNOTSUPP is returned from qed_mcp_bist_nvm_get_num_images() ensure
nvm_info.num_images is set to 0 to avoid possible uninit assignment
to p_hwfn->nvm_info.image_att later on in out label.

Closes: https://scan5.scan.coverity.com/#/project-view/63204/10063?selectedIssue=1636666
Suggested-by: Simon Horman <horms@kernel.org>
Signed-off-by: Gianfranco Trad <gianf.trad@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241215011733.351325-2-gianf.trad@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/qlogic/qed/qed_mcp.c