]> www.infradead.org Git - users/willy/xarray.git/commit
kunit: Protect string comparisons against NULL
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Wed, 20 Dec 2023 15:52:56 +0000 (15:52 +0000)
committerShuah Khan <skhan@linuxfoundation.org>
Wed, 3 Jan 2024 16:10:04 +0000 (09:10 -0700)
commit7ece381aa72d430ee117958abb5bb23e21d72f1d
treeb5abec86c9f20faa32dd3ccae6d29aa69512c454
parent5fb1a8c671473c59ed556035346fa9f2b2b430f1
kunit: Protect string comparisons against NULL

Add NULL checks to KUNIT_BINARY_STR_ASSERTION() so that it will fail
cleanly if either pointer is NULL, instead of causing a NULL pointer
dereference in the strcmp().

A test failure could be that a string is unexpectedly NULL. This could
be trapped by KUNIT_ASSERT_NOT_NULL() but that would terminate the test
at that point. It's preferable that the KUNIT_EXPECT_STR*() macros can
handle NULL pointers as a failure.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: David Gow <davidgow@google.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
include/kunit/test.h