]> www.infradead.org Git - users/hch/misc.git/commit
badblocks: Fix a nonsense WARN_ON() which checks whether a u64 variable < 0
authorColy Li <colyli@kernel.org>
Sun, 9 Mar 2025 16:05:56 +0000 (12:05 -0400)
committerJens Axboe <axboe@kernel.dk>
Mon, 10 Mar 2025 13:41:58 +0000 (07:41 -0600)
commit7e76336e14de9a2b67af96012ddd46c5676cf340
treeab197e8a5e2b5e75f1c01ae3e4fbbb2a826c3db6
parentfc0e982b8a3a169b1c654d9a1aa45bf292943ef2
badblocks: Fix a nonsense WARN_ON() which checks whether a u64 variable < 0

In _badblocks_check(), there are lines of code like this,
1246         sectors -= len;
[snipped]
1251         WARN_ON(sectors < 0);

The WARN_ON() at line 1257 doesn't make sense because sectors is
unsigned long long type and never to be <0.

Fix it by checking directly checking whether sectors is less than len.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Coly Li <colyli@kernel.org>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20250309160556.42854-1-colyli@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/badblocks.c