]> www.infradead.org Git - users/dwmw2/linux.git/commit
ARC: bpf: Correct conditional check in 'check_jmp_32'
authorHardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Wed, 13 Nov 2024 13:41:18 +0000 (19:11 +0530)
committerVineet Gupta <vgupta@kernel.org>
Tue, 10 Dec 2024 18:12:56 +0000 (10:12 -0800)
commit7dd9eb6ba88964b091b89855ce7d2a12405013af
treea16ba8c4becc929d71a7611f0b4f5b2de20330db
parent4d93ffe661ff59d2d66231b4054fe9c9658bd16c
ARC: bpf: Correct conditional check in 'check_jmp_32'

The original code checks 'if (ARC_CC_AL)', which is always true since
ARC_CC_AL is a constant. This makes the check redundant and likely
obscures the intention of verifying whether the jump is conditional.

Updates the code to check cond == ARC_CC_AL instead, reflecting the intent
to differentiate conditional from unconditional jumps.

Suggested-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Acked-by: Shahab Vahedi <list+bpf@vahedi.org>
Signed-off-by: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Signed-off-by: Vineet Gupta <vgupta@kernel.org>
arch/arc/net/bpf_jit_arcv2.c