]> www.infradead.org Git - users/jedix/linux-maple.git/commit
can: mcp251x: fix deadlock if an interrupt occurs during mcp251x_open
authorSimon Arlott <simon@octiron.net>
Thu, 22 Aug 2024 07:25:07 +0000 (08:25 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 22 Aug 2024 07:47:09 +0000 (09:47 +0200)
commit7dd9c26bd6cf679bcfdef01a8659791aa6487a29
tree3be7e36cbce0294efeb7278b5639eab1c914a996
parent8de78e00986e883670d79d99d174626e4d4dabc5
can: mcp251x: fix deadlock if an interrupt occurs during mcp251x_open

The mcp251x_hw_wake() function is called with the mpc_lock mutex held and
disables the interrupt handler so that no interrupts can be processed while
waking the device. If an interrupt has already occurred then waiting for
the interrupt handler to complete will deadlock because it will be trying
to acquire the same mutex.

CPU0                           CPU1
----                           ----
mcp251x_open()
 mutex_lock(&priv->mcp_lock)
  request_threaded_irq()
                               <interrupt>
                               mcp251x_can_ist()
                                mutex_lock(&priv->mcp_lock)
  mcp251x_hw_wake()
   disable_irq() <-- deadlock

Use disable_irq_nosync() instead because the interrupt handler does
everything while holding the mutex so it doesn't matter if it's still
running.

Fixes: 8ce8c0abcba3 ("can: mcp251x: only reset hardware as required")
Signed-off-by: Simon Arlott <simon@octiron.net>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/4fc08687-1d80-43fe-9f0d-8ef8475e75f6@0882a8b5-c6c3-11e9-b005-00805fc181fe.uuid.home.arpa
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/spi/mcp251x.c