]> www.infradead.org Git - users/hch/configfs.git/commit
drm/xe/rtp: Fix out-of-bounds array access
authorLucas De Marchi <lucas.demarchi@intel.com>
Fri, 28 Jun 2024 16:17:26 +0000 (09:17 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Mon, 1 Jul 2024 17:49:19 +0000 (10:49 -0700)
commit7dc10eff223b0e9fed5d48159820556a576be592
treef49e566984a7f7b59430a1b805e1c87048326cac
parent411220808ceeaf91b11a9fa9bc992d59568a7ee0
drm/xe/rtp: Fix out-of-bounds array access

Increment the counter before checking for number of rules, otherwise
when there's no XE_RTP_MATCH_OR an out-of-bounds access is done, as
reported by kasan:

BUG: KASAN: global-out-of-bounds in rule_matches+0xb6d/0x11c0 [xe]
Read of size 1 at addr ffffffffa0a50b70 by task systemd-udevd/243

Fixes: dc72c52a42e0 ("drm/xe/rtp: Allow to OR rules")
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240628161726.836734-1-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_rtp.c