]> www.infradead.org Git - users/jedix/linux-maple.git/commit
btrfs: fix the ASSERT() inside GET_SUBPAGE_BITMAP()
authorQu Wenruo <wqu@suse.com>
Tue, 1 Apr 2025 07:50:28 +0000 (18:20 +1030)
committerDavid Sterba <dsterba@suse.com>
Thu, 17 Apr 2025 09:55:56 +0000 (11:55 +0200)
commit7d82240c457fc15abdf7dedf15104cea774b005b
tree9195d53179064d68b0af20472a246c602ef436d3
parentbc2dbc4983afedd198490cca043798f57c93e9bf
btrfs: fix the ASSERT() inside GET_SUBPAGE_BITMAP()

After enabling large data folios for tests, I hit the ASSERT() inside
GET_SUBPAGE_BITMAP() where blocks_per_folio matches BITS_PER_LONG.

The ASSERT() itself is only based on the original subpage fs block size,
where we have at most 16 blocks per page, thus
"ASSERT(blocks_per_folio < BITS_PER_LONG)".

However the experimental large data folio support will set the max folio
order according to the BITS_PER_LONG, so we can have a case where a large
folio contains exactly BITS_PER_LONG blocks.

So the ASSERT() is too strict, change it to
"ASSERT(blocks_per_folio <= BITS_PER_LONG)" to avoid the false alert.

Reviewed-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Reviewed-by: Boris Burkov <boris@bur.io>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/subpage.c