]> www.infradead.org Git - users/dwmw2/linux.git/commit
riscv: uprobes: Add missing fence.i after building the XOL buffer
authorBjörn Töpel <bjorn@rivosinc.com>
Sat, 19 Apr 2025 11:14:00 +0000 (13:14 +0200)
committerPalmer Dabbelt <palmer@rivosinc.com>
Thu, 24 Apr 2025 20:20:02 +0000 (13:20 -0700)
commit7d1d19a11cfbfd8bae1d89cc010b2cc397cd0c48
tree636578fba96a4fd297bc1964e2e7a1812576ff0a
parent121f34341d396b666d8a90b24768b40e08ca0d61
riscv: uprobes: Add missing fence.i after building the XOL buffer

The XOL (execute out-of-line) buffer is used to single-step the
replaced instruction(s) for uprobes. The RISC-V port was missing a
proper fence.i (i$ flushing) after constructing the XOL buffer, which
can result in incorrect execution of stale/broken instructions.

This was found running the BPF selftests "test_progs:
uprobe_autoattach, attach_probe" on the Spacemit K1/X60, where the
uprobes tests randomly blew up.

Reviewed-by: Guo Ren <guoren@kernel.org>
Fixes: 74784081aac8 ("riscv: Add uprobes supported")
Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
Link: https://lore.kernel.org/r/20250419111402.1660267-2-bjorn@kernel.org
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/kernel/probes/uprobes.c