]> www.infradead.org Git - users/dwmw2/linux.git/commit
vsock/test: fix failures due to wrong SO_RCVLOWAT parameter
authorKonstantin Shkolnyy <kshk@linux.ibm.com>
Tue, 3 Dec 2024 15:06:54 +0000 (09:06 -0600)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 5 Dec 2024 10:39:33 +0000 (11:39 +0100)
commit7ce1c0921a806ee7d4bb24f74a3b30c89fc5fb39
treed9f3b853c69cba7d34bd8b3b4a973ecc72731637
parent4615855ea8c42aff76cc7772509445dc80bcd917
vsock/test: fix failures due to wrong SO_RCVLOWAT parameter

This happens on 64-bit big-endian machines.
SO_RCVLOWAT requires an int parameter. However, instead of int, the test
uses unsigned long in one place and size_t in another. Both are 8 bytes
long on 64-bit machines. The kernel, having received the 8 bytes, doesn't
test for the exact size of the parameter, it only cares that it's >=
sizeof(int), and casts the 4 lower-addressed bytes to an int, which, on
a big-endian machine, contains 0. 0 doesn't trigger an error, SO_RCVLOWAT
returns with success and the socket stays with the default SO_RCVLOWAT = 1,
which results in vsock_test failures, while vsock_perf doesn't even notice
that it's failed to change it.

Fixes: b1346338fbae ("vsock_test: POLLIN + SO_RCVLOWAT test")
Fixes: 542e893fbadc ("vsock/test: two tests to check credit update logic")
Fixes: 8abbffd27ced ("test/vsock: vsock_perf utility")
Signed-off-by: Konstantin Shkolnyy <kshk@linux.ibm.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
tools/testing/vsock/vsock_perf.c
tools/testing/vsock/vsock_test.c