]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xfs: Fix missed holes in SEEK_HOLE implementation
authorJan Kara <jack@suse.cz>
Thu, 18 May 2017 23:36:22 +0000 (16:36 -0700)
committerShan Hai <shan.hai@oracle.com>
Thu, 9 Nov 2017 01:51:57 +0000 (09:51 +0800)
commit7c8eac79fba1999af64801848c0dd482aca50b29
treeeba0b71a1e9e943a05a1f287dc8a66b48603c316
parente10e9e4ba840b43697b57d9d5faeab87492d2b45
xfs: Fix missed holes in SEEK_HOLE implementation

XFS SEEK_HOLE implementation could miss a hole in an unwritten extent as
can be seen by the following command:

xfs_io -c "falloc 0 256k" -c "pwrite 0 56k" -c "pwrite 128k 8k"
       -c "seek -h 0" file
wrote 57344/57344 bytes at offset 0
56 KiB, 14 ops; 0.0000 sec (49.312 MiB/sec and 12623.9856 ops/sec)
wrote 8192/8192 bytes at offset 131072
8 KiB, 2 ops; 0.0000 sec (70.383 MiB/sec and 18018.0180 ops/sec)
Whence Result
HOLE 139264

Where we can see that hole at offset 56k was just ignored by SEEK_HOLE
implementation. The bug is in xfs_find_get_desired_pgoff() which does
not properly detect the case when pages are not contiguous.

Fix the problem by properly detecting when found page has larger offset
than expected.

CC: stable@vger.kernel.org
Fixes: d126d43f631f996daeee5006714fed914be32368
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Orabug: 27093425

(backport upstream commit 5375023ae1266553a7baa0845e82917d8803f48c)

Signed-off-by: Shan Hai <shan.hai@oracle.com>
fs/xfs/xfs_file.c