]> www.infradead.org Git - users/jedix/linux-maple.git/commit
rust: sync: implement `Default` for `LockClassKey`
authorMiguel Ojeda <ojeda@kernel.org>
Mon, 1 Apr 2024 21:23:01 +0000 (23:23 +0200)
committerMiguel Ojeda <ojeda@kernel.org>
Sun, 5 May 2024 17:22:25 +0000 (19:22 +0200)
commit7c81aa85eee536f36ad79339bbbc7528a49d30fe
treeeaeba2199283f7d4c84f96a20275932ae499c5f3
parentae58351a8a44fc017fed085246a08ce4ecf1acd6
rust: sync: implement `Default` for `LockClassKey`

In the upcoming Rust 1.78.0, Clippy suggests to implement `Default` even
when `new()` is `const`, since `Default::default()` may call `const`
functions even if it is not `const` itself [1]:

    error: you should consider adding a `Default` implementation for `LockClassKey`
      --> rust/kernel/sync.rs:31:5
       |
    31 | /     pub const fn new() -> Self {
    32 | |         Self(Opaque::uninit())
    33 | |     }
       | |_____^

Thus implement it.

Link: https://github.com/rust-lang/rust-clippy/pull/10903
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20240401212303.537355-2-ojeda@kernel.org
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
rust/kernel/sync.rs