]> www.infradead.org Git - users/jedix/linux-maple.git/commit
nvme: fix metadata handling in nvme-passthrough
authorPuranjay Mohan <pjy@amazon.com>
Thu, 29 Aug 2024 13:32:17 +0000 (13:32 +0000)
committerKeith Busch <kbusch@kernel.org>
Fri, 30 Aug 2024 14:50:29 +0000 (07:50 -0700)
commit7c2fd76048e95dd267055b5f5e0a48e6e7c81fd9
tree5d4275f5615c95f64945745230fd09fd8c354f91
parentcead0b8991713bdeb5b947758dd62287fcf8da40
nvme: fix metadata handling in nvme-passthrough

On an NVMe namespace that does not support metadata, it is possible to
send an IO command with metadata through io-passthru. This allows issues
like [1] to trigger in the completion code path.
nvme_map_user_request() doesn't check if the namespace supports metadata
before sending it forward. It also allows admin commands with metadata to
be processed as it ignores metadata when bdev == NULL and may report
success.

Reject an IO command with metadata when the NVMe namespace doesn't
support it and reject an admin command if it has metadata.

[1] https://lore.kernel.org/all/mb61pcylvnym8.fsf@amazon.com/

Suggested-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Puranjay Mohan <pjy@amazon.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Anuj Gupta <anuj20.g@samsung.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/ioctl.c