]> www.infradead.org Git - users/dwmw2/linux.git/commit
block: mark GFP_NOIO around sysfs ->store()
authorMing Lei <tom.leiming@gmail.com>
Mon, 13 Jan 2025 01:58:33 +0000 (09:58 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 13 Jan 2025 14:45:03 +0000 (07:45 -0700)
commit7c0be4ead1f8f5f8be0803f347de0de81e3b8e1c
tree47612f3004d5906baec9d2ea00ff743dd8379893
parent9752b55035b161e40220b9ec8fae6e363a601996
block: mark GFP_NOIO around sysfs ->store()

sysfs ->store is called with queue freezed, meantime we have several
->store() callbacks(update_nr_requests, wbt, scheduler) to allocate
memory with GFP_KERNEL which may run into direct reclaim code path,
then potential deadlock can be caused.

Fix the issue by marking NOIO around sysfs ->store()

Reported-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20250113015833.698458-1-ming.lei@redhat.com
Link: https://lore.kernel.org/linux-block/Z4RkemI9f6N5zoEF@fedora/T/#mc774c65eeca5c024d29695f9ac6152b87763f305
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-sysfs.c