]> www.infradead.org Git - users/jedix/linux-maple.git/commit
rbd: don't leak parent_spec in rbd_dev_probe_parent()
authorIlya Dryomov <idryomov@gmail.com>
Sun, 11 Oct 2015 17:38:00 +0000 (19:38 +0200)
committerChuck Anderson <chuck.anderson@oracle.com>
Fri, 5 Feb 2016 03:28:19 +0000 (19:28 -0800)
commit7be1f29db563eba108fa8bf907b457edfd4383f4
treeba36de5f9fafaeec59848f043904cbbd688353ca
parent314e333edaccb1d35831844bf54f49695dfeb445
rbd: don't leak parent_spec in rbd_dev_probe_parent()

Orabug: 22623813

commit 1f2c6651f69c14d0d3a9cfbda44ea101b02160ba upstream.

Currently we leak parent_spec and trigger a "parent reference
underflow" warning if rbd_dev_create() in rbd_dev_probe_parent() fails.
The problem is we take the !parent out_err branch and that only drops
refcounts; parent_spec that would've been freed had we called
rbd_dev_unparent() remains and triggers rbd_warn() in
rbd_dev_parent_put() - at that point we have parent_spec != NULL and
parent_ref == 0, so counter ends up being -1 after the decrement.

Redo rbd_dev_probe_parent() to fix this.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
[idryomov@gmail.com: backport to < 4.2: rbd_dev->opts]
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 10f560cde4edf75af70eb55c0e55b3a04fcb6b31)
Signed-off-by: Dan Duval <dan.duval@oracle.com>
drivers/block/rbd.c