]> www.infradead.org Git - users/jedix/linux-maple.git/commit
spi: cadence: Fix out-of-bounds array access in cdns_mrvl_xspi_setup_clock()
authorJosh Poimboeuf <jpoimboe@kernel.org>
Mon, 31 Mar 2025 15:33:32 +0000 (08:33 -0700)
committerMark Brown <broonie@kernel.org>
Mon, 31 Mar 2025 15:38:32 +0000 (16:38 +0100)
commit7ba0847fa1c22e7801cebfe5f7b75aee4fae317e
tree9d8f6f3bdfcc2e9ff76bb54b715bc97f66296a56
parent40369bfe717e96e26650eeecfa5a6363563df6e4
spi: cadence: Fix out-of-bounds array access in cdns_mrvl_xspi_setup_clock()

If requested_clk > 128, cdns_mrvl_xspi_setup_clock() iterates over the
entire cdns_mrvl_xspi_clk_div_list array without breaking out early,
causing 'i' to go beyond the array bounds.

Fix that by stopping the loop when it gets to the last entry, clamping
the clock to the minimum 6.25 MHz.

Fixes the following warning with an UBSAN kernel:

  vmlinux.o: warning: objtool: cdns_mrvl_xspi_setup_clock: unexpected end of section .text.cdns_mrvl_xspi_setup_clock

Fixes: 26d34fdc4971 ("spi: cadence: Add clock configuration for Marvell xSPI overlay")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202503282236.UhfRsF3B-lkp@intel.com/
Link: https://lore.kernel.org/r/gs2ooxfkblnee6cc5yfcxh7nu4wvoqnuv4lrllkhccxgcac2jg@7snmwd73jkhs
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Link: https://patch.msgid.link/h6bef6wof6zpjfp3jbhrkigqsnykdfy6j4qmmvb6gsabhianhj@k57a7hwpa3bj
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence-xspi.c