]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: sched: do not requeue a NULL skb
authorLars Persson <lars.persson@axis.com>
Tue, 12 Apr 2016 06:45:52 +0000 (08:45 +0200)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:22:02 +0000 (17:22 -0500)
commit7b12877e3786b3138c054b35a24f6c43d17d8395
treef3a038f51a87d384ea6764d1dedf337287173435
parent5ef79bb96cd69c293922c5b38022c59d18a3205e
net: sched: do not requeue a NULL skb

Orabug: 25308077

[ Upstream commit 3dcd493fbebfd631913df6e2773cc295d3bf7d22 ]

A failure in validate_xmit_skb_list() triggered an unconditional call
to dev_requeue_skb with skb=NULL. This slowly grows the queue
discipline's qlen count until all traffic through the queue stops.

We take the optimistic approach and continue running the queue after a
failure since it is unknown if later packets also will fail in the
validate path.

Fixes: 55a93b3ea780 ("qdisc: validate skb without holding lock")
Signed-off-by: Lars Persson <larper@axis.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 5730fd5d72071c9ae96929292351029ea56de7c0)
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
net/sched/sch_generic.c