]> www.infradead.org Git - users/dwmw2/linux.git/commit
ath5k: fix memory leak on buf on failed eeprom read
authorColin Ian King <colin.king@canonical.com>
Wed, 3 May 2017 14:26:00 +0000 (15:26 +0100)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:25 +0000 (21:36 -0400)
commit7a43a45f7a96bb166348116963d3536644a63cc2
tree47aa4cf38bfe206a54e63edc861a7a59ca80da52
parentfc1b7eb4c81e633436ad5c60e6a3aa0a5c27588e
ath5k: fix memory leak on buf on failed eeprom read

[ Upstream commit 8fed6823e06e43ee9cf7c0ffecec2f9111ce6201 ]

The AR5K_EEPROM_READ macro returns with -EIO if a read error
occurs causing a memory leak on the allocated buffer buf. Fix
this by explicitly calling ath5k_hw_nvram_read and exiting on
the via the freebuf label that performs the necessary free'ing
of buf when a read error occurs.

Detected by CoverityScan, CID#1248782 ("Resource Leak")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/net/wireless/ath/ath5k/debug.c