]> www.infradead.org Git - users/willy/pagecache.git/commit
rxrpc: Fix uninitialised variable in rxrpc_send_data()
authorDavid Howells <dhowells@redhat.com>
Tue, 1 Oct 2024 13:26:59 +0000 (14:26 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 3 Oct 2024 23:23:21 +0000 (16:23 -0700)
commit7a310f8d7dfe2d92a1f31ddb5357bfdd97eed273
tree3bb430c50acdb9493e56b03eb93a6641648cf20a
parentbc212465326e8587325f520a052346f0b57360e6
rxrpc: Fix uninitialised variable in rxrpc_send_data()

Fix the uninitialised txb variable in rxrpc_send_data() by moving the code
that loads it above all the jumps to maybe_error, txb being stored back
into call->tx_pending right before the normal return.

Fixes: b0f571ecd794 ("rxrpc: Fix locking in rxrpc's sendmsg")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lists.infradead.org/pipermail/linux-afs/2024-October/008896.html
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Link: https://patch.msgid.link/20241001132702.3122709-3-dhowells@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/rxrpc/sendmsg.c