]> www.infradead.org Git - users/dwmw2/qemu.git/commit
xen: do not use '%ms' scanf specifier
authorRoger Pau Monne <roger.pau@citrix.com>
Fri, 10 Jan 2025 09:35:31 +0000 (10:35 +0100)
committerDavid Woodhouse <dwmw@amazon.co.uk>
Wed, 15 Jan 2025 17:06:49 +0000 (17:06 +0000)
commit7a0b74d8716836f1206c5dfd778984c5d6eee46b
treee4c8e9a6de9460fb4a303ef6971c1ab8ac26c7fc
parente6cdeee95990a2c6f5d6873d3afb3c90518aed5c
xen: do not use '%ms' scanf specifier

The 'm' parameter used to request auto-allocation of the destination variable
is not supported on FreeBSD, and as such leads to failures to parse.

What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as
it just leads to a double allocation of the same string.  Instead use
xs_node_read() to read the whole xenstore node.

Fixes: a783f8ad4ec9 ('xen: add a mechanism to automatically create XenDevice-s...')
Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>
hw/block/xen-block.c
hw/char/xen_console.c
hw/xen/xen-bus.c
include/hw/xen/xen-bus.h