]> www.infradead.org Git - nvme.git/commit
nvme-fabrics: fix I/O connect error handling
authorChaitanya Kulkarni <kch@nvidia.com>
Tue, 13 Feb 2024 08:26:46 +0000 (00:26 -0800)
committerKeith Busch <kbusch@kernel.org>
Tue, 13 Feb 2024 16:16:10 +0000 (08:16 -0800)
commit79bd7eab8366b29eaa099908d5694cb473684b9d
tree5fab09e50e916e4fcc18c1cc50f5c7deb1e66aae
parent5f63a493b99c848ad5200402bebe26211e00025a
nvme-fabrics: fix I/O connect error handling

In nvmf_connect_io_queue(), if connect I/O command fails, we log the
error and continue for authentication. This overrides error captured
from __nvme_submit_sync_cmd(), causing wrong return value.

Add goto out_free_data after logging connect error to fix the issue.

Fixes: f50fff73d620c ("nvme: implement In-Band authentication")
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/fabrics.c