]> www.infradead.org Git - users/dwmw2/qemu.git/commit
net/vmnet: Pad short Ethernet frames
authorWilliam Hooper <wsh@wshooper.org>
Sat, 6 Jan 2024 22:35:46 +0000 (14:35 -0800)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 31 Dec 2024 20:21:34 +0000 (21:21 +0100)
commit79b6a98587c65c8b8fdde8eb778396f1fc98a852
tree354465284fbf512e6af3fd72a8e6fb198e867738
parent67e908c936b5f568b2ee913c1558e0235cd96293
net/vmnet: Pad short Ethernet frames

At least on macOS 12.7.2, vmnet doesn't pad Ethernet frames, such as the
host's ARP replies, to the minimum size (60 bytes before the frame check
sequence) defined in IEEE Std 802.3-2022, so guests' Ethernet device
drivers may drop them with "frame too short" errors.

This patch calls eth_pad_short_frame() to add padding, as in net/tap.c
and net/slirp.c. Thanks to Bin Meng, Philippe Mathieu-Daudé, and Phil
Dennis-Jordan for reviewing earlier versions.

Signed-off-by: William Hooper <wsh@wshooper.org>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2058
Reviewed-by: Phil Dennis-Jordan <phil@philjordan.eu>
Message-ID: <20241102205653.30476-1-wsh@wshooper.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
net/vmnet-common.m