]> www.infradead.org Git - users/jedix/linux-maple.git/commit
pwm: ab8500: Fix register offset calculation to not depend on probe order
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 5 Jul 2021 16:55:10 +0000 (18:55 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 19 Aug 2021 13:39:51 +0000 (15:39 +0200)
commit7954f76161eab5b87f3f60a3d1326e798dd44b7d
tree5dc909b8e7f8ff9e430592ac173a7ca2cfc8066e
parent5e913a126f6244e5d66d457f09134970a326daa6
pwm: ab8500: Fix register offset calculation to not depend on probe order

The assumption that lead to commit 5e5da1e9fbee ("pwm: ab8500:
Explicitly allocate pwm chip base dynamically") was wrong: The
pwm-ab8500 devices are not directly instantiated from device tree, but
from the ab8500 mfd driver. So the pdev->id isn't -1, but a number
between 1 and 3. Now that pwmchip ids are always allocated dynamically,
this cannot easily be reverted.

Introduce a new member in the driver data struct that tracks the
hardware id and use this to calculate the register offset.

Side-note: Using chip->base to calculate the offset was never robust
because if there was already a PWM with id 1 at the time ab8500-pwm.1
was probed, the associated pwmchip would get assigned chip->base = 2 (or
something bigger).

Fixes: 5e5da1e9fbee ("pwm: ab8500: Explicitly allocate pwm chip base dynamically")
Fixes: 6173f8f4ed9c ("pwm: Move AB8500 PWM driver to PWM framework")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-ab8500.c