]> www.infradead.org Git - users/hch/misc.git/commit
block: remove unnecessary goto labels in debugfs attribute read methods
authorNilay Shroff <nilay@linux.ibm.com>
Thu, 13 Mar 2025 11:51:51 +0000 (17:21 +0530)
committerJens Axboe <axboe@kernel.dk>
Thu, 13 Mar 2025 13:23:14 +0000 (07:23 -0600)
commit78800f5997d8ae0f20d4aced66a524f0f2fc4c7f
tree2c9eb2767a212424d413ecd96dd05906c314160a
parenta3996d11f3ab743e6cc4e3529ce9459c2cd27139
block: remove unnecessary goto labels in debugfs attribute read methods

In some debugfs attribute read methods, failure to acquire the mutex
lock results in jumping to a label before returning an error code.
However this is unnecessary, as we can return the failure code directly,
improving code readability and reducing complexity.

This commit removes the goto labels and ensures that the method returns
immediately upon failing to acquire the mutex lock.

Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20250313115235.3707600-3-nilay@linux.ibm.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq-debugfs.c